Make setMaintainVisibleContentPosition and MaintainVisibleScrollPositionHelper internal#57077
Closed
cortinico wants to merge 1 commit into
Closed
Make setMaintainVisibleContentPosition and MaintainVisibleScrollPositionHelper internal#57077cortinico wants to merge 1 commit into
setMaintainVisibleContentPosition and MaintainVisibleScrollPositionHelper internal#57077cortinico wants to merge 1 commit into
Conversation
…sitionHelper` internal Summary: `setMaintainVisibleContentPosition` takes a `MaintainVisibleScrollPositionHelper.Config` parameter whose constructor is `internal`, making the method uncallable by OSS consumers. This change makes both the method and the helper class `internal` to reflect that reality and reduce the public API surface. Changelog: [Internal] Differential Revision: D107530272
meta-cla
Bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107530272. |
|
This pull request has been merged in 503c0a5. |
Collaborator
|
This pull request was successfully merged by @cortinico in 503c0a5 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
setMaintainVisibleContentPositiontakes aMaintainVisibleScrollPositionHelper.Configparameter whose constructor isinternal, making the method uncallable by OSS consumers. This change makes both the method and the helper classinternalto reflect that reality and reduce the public API surface.Changelog: [Internal]
Differential Revision: D107530272